perf: Skip no-op image enhancements - #742
Merged
Merged
Conversation
ImageEnhance.enhance(1.0) still blends over the entire image, so the default settings ran four full-frame passes on every render. Skip any enhancement whose factor is 1.0. Output is identical since a factor of 1.0 returns the original pixels. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Optimizes the image rendering pipeline by avoiding expensive, no-op PIL enhancement passes when enhancement factors are left at their defaults, reducing per-render work on constrained devices.
Changes:
- Replaces four unconditional
ImageEnhance.*.enhance(...)calls with a loop over configured enhancements. - Skips any enhancement whose factor is
1.0to avoid full-frame blend passes with no pixel change.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
phattmatt
self-requested a review
August 19, 2026 19:10
phattmatt
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageEnhance.enhance(1.0) still blends over the entire image, so the default settings ran four full-frame passes on every render. Skip any enhancement whose factor is 1.0. Output is identical since a factor of 1.0 returns the original pixels.